Fixing and adding test for combine kwarg in reaction.add_metabolites #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## devel #503 +/- ##
=========================================
+ Coverage 69% 69.04% +0.03%
=========================================
Files 64 64
Lines 8460 8469 +9
Branches 1443 1445 +2
=========================================
+ Hits 5838 5847 +9
Misses 2366 2366
Partials 256 256
Continue to review full report at Codecov.
|
|
I know this is done and merged. Just wondering why the use of |
|
Yeah I guess you're right, no real reason behind iterkeys |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously using
reaction.add_metabolites(*args, combine=False)in a model context would result in the wrong reaction being returned.